Allow find and replace metadata and do not error when file not found. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
person-al
commented
Jun 24, 2021
| dated_name, _, _ = dated_file_index[link_name_slug] | ||
| rewritten = rewritten.replace( | ||
| link, f'[{link_text}]({generate_post_link(dated_name, post_link_mode)})') | ||
| dated_name, _, _ = dated_file_index.get(link_name_slug, (None, None, None)) |
There was a problem hiding this comment.
Right now, if a file has a [[ link to a file that doesn't exist yet, obdye errors out. This change makes it skip replacing the link instead.
person-al
force-pushed
the
person/find-replace
branch
from
f2a7b0d
to
6410c16
Compare
person-al
force-pushed
the
person/find-replace
branch
from
6410c16
to
ea306c4
Compare
|
Nice addition, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow find and replace metadata so you can modify files systematically before publishing them. This is helpful when removing extra status information from files before publishing. Additionally, do not error out if you cannot find a file for a given Obsidian link