You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After a quick dig into the code, I might need to take a little bit more time to make a refactor:
Currently the openings is a list of days related to hour spans -> I think this is wrong, if you want to have exceptional openings, this is limiting
Closing is a list of time spans -> This is the reverse issue of 1., I should make sure both openings and closings actually supports time spans and day/hour spans
The code is outdated (by basically 2-3 years) -> I would like to bring support for newest Node.Js versions (currently the package only support Node <= 14, newest is 19)
Once I did this, I will be able to refactor the code to avoid working with hand-made date manipulation functions but using a state-of-the-art Date manipulation, I am used to use Carbon for PHP which lifts a lot of burden regarding this kind of task looking for something similar in JS to be able to work with Intervals etc...)
Hope it sounds ok and you're not in a hurry, sorry for the inconvenience!
Great project!
I would appreciate methods openIn() and openAt() which could be the counterparts to closeIn() and closeAt().
What do you think?
The text was updated successfully, but these errors were encountered: