Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New method openIn #2

Open
thomasv opened this issue Mar 12, 2019 · 4 comments
Open

New method openIn #2

thomasv opened this issue Mar 12, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@thomasv
Copy link

thomasv commented Mar 12, 2019

Great project!
I would appreciate methods openIn() and openAt() which could be the counterparts to closeIn() and closeAt().
What do you think?

@khalyomede
Copy link
Owner

I think this would comes handy, working on it :). Thank you for your time filling an issue.

@khalyomede khalyomede self-assigned this Mar 12, 2019
@khalyomede khalyomede added enhancement New feature or request good first issue Good for newcomers labels Mar 12, 2019
@fgerards
Copy link

any scatches on that functionality ?

@khalyomede
Copy link
Owner

Sorry Franck, got completely absorbed on another side project. Will give it a try this weekend thanks for your patience 🙏

@khalyomede
Copy link
Owner

khalyomede commented Mar 12, 2023

After a quick dig into the code, I might need to take a little bit more time to make a refactor:

  1. Currently the openings is a list of days related to hour spans -> I think this is wrong, if you want to have exceptional openings, this is limiting
  2. Closing is a list of time spans -> This is the reverse issue of 1., I should make sure both openings and closings actually supports time spans and day/hour spans
  3. The code is outdated (by basically 2-3 years) -> I would like to bring support for newest Node.Js versions (currently the package only support Node <= 14, newest is 19)
  4. Once I did this, I will be able to refactor the code to avoid working with hand-made date manipulation functions but using a state-of-the-art Date manipulation, I am used to use Carbon for PHP which lifts a lot of burden regarding this kind of task looking for something similar in JS to be able to work with Intervals etc...)

Hope it sounds ok and you're not in a hurry, sorry for the inconvenience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants