Skip to content
This repository has been archived by the owner on Nov 28, 2018. It is now read-only.

code review initial commit #1

Open
kevinbarabash opened this issue Dec 13, 2017 · 1 comment
Open

code review initial commit #1

kevinbarabash opened this issue Dec 13, 2017 · 1 comment
Assignees

Comments

@kevinbarabash
Copy link
Contributor

kevinbarabash commented Dec 13, 2017

I messed up and commit the actually implementation in my first commit instead of have a placeholder commit to make a PR against.

The goal of this webpack loader is to implement the same semantics as the "plugins" option in third_party_js.py in webapp. This is accomplished by appending require statements to the module being loaded. Which modules are loaded by these new require statements is specified as a comma separate lists of paths in the loader's query parameter.

The test plan for 95c5134 is:

  • npm run test

@jeresig could you have a look at that commit and let me know if you have any concerns?

@kevinbarabash kevinbarabash changed the title code review code review initial commit Dec 13, 2017
@kevinbarabash
Copy link
Contributor Author

FYI, I'm going to have to rewrite this b/c it's doing the wrong thing, see #2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants