Fixes for expFeatures.js #1419
Merged
Fixes for expFeatures.js #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afonsojramos
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error caused by setting a property on
activePropertiesthat doesn't exist (anymore?). The property was retrieved from localStorage. In my case the key was '58'.It also fixes #1417. The experimental features didn't render anymore, because of outdated use of properties on the
resolverobject.I was testing with the 'enhance playlist' feature, and noticed toggling the feature required a reload to show up in the UI. Would be nice to automatically reload Spotify on closing the popup window, but I don't see a way to detect the window closing.
Also the 'Show "Made For You" entry point in the left sidebar' feature seems to be broken, not sure if we can do anything about that.