Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds support for CocoaPods and Swift PM #12

Merged
merged 1 commit into from Sep 30, 2017
Merged

adds support for CocoaPods and Swift PM #12

merged 1 commit into from Sep 30, 2017

Conversation

brennanMKE
Copy link
Contributor

I've added the necessary support for CocoaPods and SwiftPM.

  • Retain name of Promise on CocoaPods or change to a unique name
  • Merge PR to master
  • Run the following commands below successfully
git tag 2.0.0
git push --tags
bundle install
bundle exec pod spec lint
bundle exec pod trunk push

@brennanMKE
Copy link
Contributor Author

Hey @khanlou, have you had time to chat with Orta about taking over the Promise pod?

@khanlou
Copy link
Owner

khanlou commented Mar 29, 2017

I did mention it to him, but didn't get a response. I'll try a different member of the cocoapods team.

@khanlou
Copy link
Owner

khanlou commented Apr 6, 2017

@brennanMKE okay so it looks like we can't take over old cocoapods names. i think we'd need to come up with a new name for it. any ideas?

@samsonjs
Copy link

samsonjs commented Apr 7, 2017

  • Oath
  • Pinky
  • Honor
  • Eventually
  • Later
  • PromiseNoPeopleThisIsTheGoodOne ... 🤔

@SintraWorks
Copy link

SintraWorks commented Apr 7, 2017 via email

@khanlou
Copy link
Owner

khanlou commented Apr 12, 2017

"Promises" is taken: https://github.com/CocoaPods/Specs/blob/d0ec5a65e80656c8d78e12ff19f251df879e0bc2/Specs/1/5/5/Promises/0.1.0/Promises.podspec.json

Tempted to run with Promise.v3.final-FINAL.ai

@brennanMKE
Copy link
Contributor Author

I see Promise is now deprecated on CocoaPods. Perhaps the original owner would now be willing to transfer control of the name for this implementation. cc @khanlou

https://cocoapods.org/pods/Promise

@khanlou
Copy link
Owner

khanlou commented Apr 24, 2017

@brennanMKE working on it: https://twitter.com/orta/status/855871899682918400

@randomiser
Copy link

Any progress with this btw? Would be great to be able to include this dependency easily.

@brennanMKE
Copy link
Contributor Author

I'll message the owner of the Promises lib. I know him.

@joshdholtz
Copy link

@khanlou Sending you a message in iOS Folks slack

@joshdholtz
Copy link

We should be good here now! Donated my Promises Cocoapods namespace to this cause ✊

RIP https://github.com/joshdholtz/ios-promises 💀

@randomiser
Copy link

Awesome. Thanks very much.

khanlou
khanlou reviewed Sep 17, 2017
View reviewed changes
Copy link
Owner

@khanlou khanlou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, now that we have the Promises name on cocoapods, i added a tag for v2.0 (and made some breaking changes i've been meaning to make 😈 ). @brennanMKE can you make these changes and then i'll merge and push up to pod trunk?

.swift-version
@@ -0,0 +1 @@
3.0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be 3.1 now?

Promise.podspec
@@ -0,0 +1,17 @@
Pod::Spec.new do |s|
s.name = "Promise"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change the to Promises?

Promise.podspec
s.homepage = "https://github.com/khanlou/Promise"
s.license = 'MIT'
s.author = { "Soroush Khanlou" => "soroush@khanlou.com" }
s.source = { :git => "https://github.com/khanlou/Promise.git", :tag => "2.0.0" }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the tag to v2.0

README.md
})
dependencies: [
.Package(url: "https://github.com/khanlou/Promise.git", majorVersion: 2)
]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think installation instructions should go at the end of the README. ime people have more problems understanding how they work than how to install a cocoapod. can you please update the cocoapod name here as well?

@brennanMKE
Copy link
Contributor Author

I will get to this when I have time. It may not be till this weekend.

This was referenced Sep 30, 2017
Closed
Merged
@khanlou khanlou merged commit b0d8784 into khanlou:master Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanlou khanlou khanlou left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@brennanMKE @khanlou @samsonjs @SintraWorks @randomiser @joshdholtz