Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some margin on the sides according to issue: #7 #12

Closed
wants to merge 2 commits into from

Conversation

DugarRishab
Copy link

@DugarRishab DugarRishab commented Oct 1, 2022

This Pull request resolves issue #7

image

@vercel
Copy link

vercel bot commented Oct 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
drip-ui ✅ Ready (Inspect) Visit Preview Oct 1, 2022 at 7:20AM (UTC)

@DugarRishab
Copy link
Author

@khazifire Can you please review this request and accept it.

@khazifire
Copy link
Owner

@DugarRishab will review it

@khazifire khazifire self-assigned this Oct 2, 2022
@khazifire
Copy link
Owner

I will not be merging this to the main, because it did removed some parts of the layout.

In addition, that margin issue can simply be fixed in just one line of code. If you analyzed carefully the layout component, you will realize that the children are styled with a custom container. Changes can simple be made to that css file

image

image

@khazifire khazifire closed this Oct 2, 2022
@DugarRishab
Copy link
Author

@khazifire as my understanding, some components might have been removed due to merging conflicts. And just becouse the solution to the issue was easy, doesn't mean my PR is bunk. Please stick to the proper process next time.

@khazifire
Copy link
Owner

khazifire commented Oct 2, 2022

@DugarRishab im sry if my comment was offensive, but i meant it in a positive way. And just to let you know your work was awesome, and me not merging it does not devalue your work.

And its my first time being a maintainer, so i hope you understand my short comings, and once again im truly sry if my comment was offensive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add some margin on the left and right side of the site.
2 participants