New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created Navbar Components #24
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
@Onyelaudochukwuka since most of the headers are the same with the difference being only in the hamburger menu (you can consider removing some of them, since its just duplicates) for instance (2 lines and 3 line hamburger , its the same thing), so i think you can just include the 3 lines since its the standard Thank you |
I'll fix these |
@Onyelaudochukwuka kindly squash all commits into one as this is best for any production code in order to make the VC graph cleaner |
Resolved all issues |
@Onyelaudochukwuka im glad you were able to fix the error that were in your previous pull request, something just caught my eyes as I was reviewing your work. its impressible but i think for components with nested elements, you can just create them normally instead of using json e.g. you can create nav1, nav2 component and then import them in the navbar file, that way it would be so much cleaner to update and modify later on Thank you |
π οΈ Fixes Issue
closes #17
π¨βπ» Changes proposed
βοΈ Check List (Check all the applicable boxes)
π Note to reviewers
π· Screenshots