Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for jfif files #15

Open
JBac opened this issue May 19, 2022 · 4 comments
Open

Add support for jfif files #15

JBac opened this issue May 19, 2022 · 4 comments

Comments

@JBac
Copy link

JBac commented May 19, 2022

Hi,

Any chance the jfif extension could be added to the typeMap?
I believe it just has the mime type of image/jpeg.

Thanks!

@khellang
Copy link
Owner

Hi @JBac! 👋🏻

The file is generated from mime-db, which in turn is compiled from IANA, Apache and nginx's MIME types.

If you're able to get the entry into mime-db, maybe in custom-types.json, it'll automatically trickle into this library 😄

@khellang
Copy link
Owner

BTW, looks like they've already requested some documentation for jfif; https://github.com/jshttp/mime-db/issues/177.

@loudenvier
Copy link

Still no .jfif "support". I know this list is generated directly from mime-db, which compiles from the three aforementioned sources, and this extension is not registered in any of them, but the JFIF files are handled as "image/jpeg" by all browsers and even in official sources: https://www.w3.org/Graphics/JPEG/

I'm actually adding it manually, but it would be nice to have this already packed in MimeTypes :-) Adding a post-download process to add a few common mime-types if they are missing would be great. Basically that's what I'm currently doing on my code, but I believe most people will have "faith" that this list is mostly inclusive, while, in fact, a somewhat common image format if missing :-(

@khellang
Copy link
Owner

Looks like there's a PR for it already; jshttp/mime-db#291 ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants