-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is up with version 2.4.1? #18
Comments
mp4 is officially registered with IANA as |
Hi @khellang, mp4 is also registered with IANA as The other day I started a discussion about GitHub Pages' handling of .mp4 files because I think (Just commenting here because I haven't seen many other discussions about this recent change to mime-db. I expect this will cause more things to break once there is a new release of mime-db) |
Yeah, I noticed that. Honestly, this package just picks the first media type from mime-db's list. I guess I'll have to introduce a way to override certain media types, unless we can find a good heuristic for which to pick by default. |
(hi from Pages team). I tend to agree. I have a PR open internally to prefer |
Excellent! Hope your PR is accepted! |
There is a NuGet package released with version 2.4.1 uploaded on 2023-02-21: https://www.nuget.org/packages/MimeTypes/2.4.1. It was released by Kristian Hellang, the owner of this Repository.
As of today, this repository does not contain a tag for version 2.4.1, no commits in 2023 and the code released is different from the code in this repository: Compare MimeTypes.cs.pp in this repo with
contentFiles/cs/*/MimeTypes.cs.pp
in Release 2.4.1.The differences between the code released and the code in this repository are not backwards compatible. E.g. getting the MIME type for a file with ".mp4" extension returns "application/mp4" in v2.4.1 instead of "video/mp4".
What is up with this?
The text was updated successfully, but these errors were encountered: