Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeSpoilergradient . Problems with risetime #27

Open
jschuere opened this issue Mar 6, 2024 · 1 comment
Open

makeSpoilergradient . Problems with risetime #27

jschuere opened this issue Mar 6, 2024 · 1 comment

Comments

@jschuere
Copy link

jschuere commented Mar 6, 2024

Pulseq 1.3 master

e.g. in pulseq-cest library APTw_3T_003_2uT_8block_DC95_834ms_braintumor

The makeSpoilerGradients is defined under SequenceSBB.m (path: pulseq-cest&seq-generation/SequenceBBB/SequenceBBB.m)

Line 36-39:
spoilRiseTime = 1e-3;
spoilDuration = 4500e-6+ spoilRiseTime; % [s]
[gxSpoil, gySpoil, gzSpoil] = makeSpoilerGradients(lims, spoilDuration, spoilRiseTime);

   In the following the riseTime is added one more time in the makeSpoilerGradient. 
   Line 25:
   spoilDuration = duration+riseTime; % [s]
  
  Suggestion:  
  
  Just defining spoil RiseTime  & spoilDuration

Line 36-39:
spoilRiseTime = 1e-3;
spoilDuration = 4500e-6 % [s]

and than in makeSpoilerGradient

Line 25: Instead of spoilDuration = duration+riseTime; % [s]

we rewrite this to :

           spoilDuration = duration+2* riseTime; % [s]

Otherwise the duration, which is givn as input parameter in the function "make spoiler gradient" , already includes one spoilriseTime

@schuenke
Copy link
Collaborator

schuenke commented Mar 7, 2024

This is what is already fixed in #21, no ? I think we just have to merge it. Don't really know why this didn't happen yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants