Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Obsidian picture won't render on notes after installing khoj. after remove picture renders again #816

Closed
3 of 14 tasks
NanHeSam opened this issue Jun 13, 2024 · 8 comments
Assignees
Labels
fix Fix something that isn't working as expected

Comments

@NanHeSam
Copy link

Describe the bug

A clear and concise description of what the bug is. Please include what you were expecting to happen vs. what actually happened.
picture won't render on notes after installing khoj. after remove picture renders again

To Reproduce

Steps to reproduce the behavior:

Screenshots

If applicable, add screenshots to help explain your problem.
when Khoj is enabled
image
image
when Khoj is disabled and restart obsedian
image
image

Platform

  • Server:
    • Cloud-Hosted (https://app.khoj.dev)
    • Self-Hosted Docker
    • Self-Hosted Python package
    • Self-Hosted source code
  • Client:
    • Obsidian
    • Emacs
    • Desktop app
    • Web browser
    • WhatsApp
  • OS:
    • Windows
    • macOS
    • Linux
    • Android
    • iOS

If self-hosted

  • Server Version [e.g. 1.0.1]:

Additional context

Add any other context about the problem here.

@NanHeSam NanHeSam added the fix Fix something that isn't working as expected label Jun 13, 2024
@sabaimran
Copy link
Member

Just to clarify, these are your normal notes, not something you've pasted into the Khoj panel, right?

@NanHeSam
Copy link
Author

Just to clarify, these are your normal notes, not something you've pasted into the Khoj panel, right?

Yes, it's the normal notes that i added before install Khoj

@debanjum
Copy link
Member

Hey @NanHeSam, thanks for reporting the issue! Is the image local on your file system or an external link (e.g starts with http)?

@NanHeSam
Copy link
Author

these pictures are all local file. but i just tried to embeded a image on the internet and it also has this behavior (showing normally when disabled Khoj but break when enable Khoj)
![[Pasted image 20240612182753.png]]
![Engelbart](https://history-computer.com/ModernComputer/Basis/images/Engelbart.jpg)

these are the format that i'm using

@debanjum
Copy link
Member

Thanks for the details! I was able to reproduce the issue on my end.

I'll push a fix out in a bit. The next Khoj Obsidian plugin release should have resolved this bug

@NanHeSam
Copy link
Author

awesome, thank you so much for the quick fix. I will verify that once it's release

@debanjum
Copy link
Member

Hey @NanHeSam, this issue was resolved in 08c3aa4.
Let me know if you're still facing problems loading the image?

@debanjum debanjum changed the title [FIX] obsedian picture won't render on notes after installing khoj. after remove picture renders again [FIX] Obsidian picture won't render on notes after installing khoj. after remove picture renders again Jun 22, 2024
@NanHeSam
Copy link
Author

Yes, I have just test and confirmed it's resolved. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix something that isn't working as expected
Projects
None yet
Development

No branches or pull requests

3 participants