Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent memory exhaustion attacks via bincode #19

Open
ecton opened this issue May 21, 2021 · 1 comment
Open

Prevent memory exhaustion attacks via bincode #19

ecton opened this issue May 21, 2021 · 1 comment

Comments

@ecton
Copy link
Member

ecton commented May 21, 2021

We shouldn't ever use bincode::deserialize directly. The preferred method is to use the Options trait. The DefaultOptions struct talks about what options are set up by default, and the important part for us is the byte limit.

@daxpedda
Copy link
Member

When I start cleaning up Fabruic I will move all TODOs from the code into issues, this is one of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants