Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sending with other serialization formats #28

Open
ecton opened this issue Oct 27, 2021 · 0 comments · May be fixed by #39
Open

Allow sending with other serialization formats #28

ecton opened this issue Oct 27, 2021 · 0 comments · May be fixed by #39
Labels
enhancement New feature or request

Comments

@ecton
Copy link
Member

ecton commented Oct 27, 2021

Currently, bincode is forced to be the way that payloads are encoded. From looking in the code, it doesn't seem like this is a hard requirement. I'd like a mechanism to be able to change the encoding used for structures.

For many crates, bincode is a great option, but for BonsaiDb, I want the API to use a self-describing format, not bincode. Rather than force others to use Pot, I'd prefer a mechanism for me to be able to provide a serialization/deserialization implementation through a new trait rather than fabruic requiring the serialization to be done via Serde.

This would give users the most flexibility, and if they want to use serde, they can pick which encoding format to use themselves.

@ecton ecton added the enhancement New feature or request label Oct 27, 2021
@ecton ecton added this to To do in Khonsu Labs Roadmap via automation Oct 27, 2021
@ecton ecton linked a pull request Jan 5, 2022 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

1 participant