Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add self support to Reducer #44

Closed
ecton opened this issue Mar 13, 2022 · 0 comments
Closed

Add self support to Reducer #44

ecton opened this issue Mar 13, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@ecton
Copy link
Member

ecton commented Mar 13, 2022

After optimizing count() in Bonsai after adding reduce() here, I looked at storing the view reductions in Nebari's indexes ( khonsulabs/bonsaidb#76). I realized that for BonsaiDb to be able to use a View's reduce function, the Reducer needs a self that can store the view.

The problem is, where does the reducer get instantiated and stored? Or is it better to refactor the reducer to be the Root itself?

@ecton ecton added the enhancement New feature or request label Mar 13, 2022
@ecton ecton added this to To do in Khonsu Labs Roadmap via automation Mar 13, 2022
@ecton ecton closed this as completed in d769a29 May 5, 2022
Khonsu Labs Roadmap automation moved this from To do to Done May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

1 participant