Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About reproducing #41

Closed
selimfirat opened this issue Jul 18, 2020 · 1 comment
Closed

About reproducing #41

selimfirat opened this issue Jul 18, 2020 · 1 comment

Comments

@selimfirat
Copy link

Thank you for sharing this wonderful work!
In fact, I have succeeded to reproduce with higher scores :) This situation makes me wonder why this happens. Was there any project/data update or am I doing something wrong?

I followed the "To run with local or virtual environment" instructions in README.py without changing config.yaml since it says "to recreate the experiment from paper, leave as is". I obtain an absolute 3% more recall.

I obtain 0.87 precision and 0.83 recall, whereas in the paper, it is 87.5% precision and 80.0% recall.
Screen Shot 2020-07-19 at 00 37 39

@khundman
Copy link
Owner

khundman commented May 9, 2021

@selimfirat thanks for the note, I was able to reproduce this as well, and the paper is incorrect for this particular experiment. I plan to issue a revised version of the paper with this correction and another that has been found, but not sure on timing of when I'll get to that.

@khundman khundman closed this as completed Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants