-
Notifications
You must be signed in to change notification settings - Fork 473
/
namespace_method_checker.go
117 lines (95 loc) · 2.8 KB
/
namespace_method_checker.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
package authorization
import (
"fmt"
"regexp"
"strings"
api_security_v1beta "istio.io/api/security/v1beta1"
security_v1beta "istio.io/client-go/pkg/apis/security/v1beta1"
"github.com/kiali/kiali/models"
"github.com/kiali/kiali/util/httputil"
)
var methodMatcher = regexp.MustCompile(`^((\/[a-zA-Z\.]+)+)(\/[a-zA-Z]+)$`)
type NamespaceMethodChecker struct {
AuthorizationPolicy *security_v1beta.AuthorizationPolicy
Namespaces models.NamespaceNames
}
func (ap NamespaceMethodChecker) Check() ([]*models.IstioCheck, bool) {
checks, valid := make([]*models.IstioCheck, 0), true
for ruleIdx, rule := range ap.AuthorizationPolicy.Spec.Rules {
if rule == nil {
continue
}
if len(rule.From) > 0 {
toChecks, toValid := ap.validateFromField(ruleIdx, rule.From)
checks = append(checks, toChecks...)
valid = valid && toValid
}
if len(rule.To) > 0 {
fromChecks, fromValid := ap.validateToField(ruleIdx, rule.To)
checks = append(checks, fromChecks...)
valid = valid && fromValid
}
}
return checks, valid
}
func (ap NamespaceMethodChecker) validateFromField(ruleIdx int, from []*api_security_v1beta.Rule_From) ([]*models.IstioCheck, bool) {
if len(from) == 0 {
return nil, true
}
checks, valid := make([]*models.IstioCheck, 0, len(from)), true
for fromIdx, f := range from {
if f == nil {
continue
}
if f.Source == nil {
continue
}
if len(f.Source.Namespaces) == 0 {
continue
}
for i, n := range f.Source.Namespaces {
if !ap.Namespaces.Includes(n) {
valid = true
path := fmt.Sprintf("spec/rules[%d]/from[%d]/source/namespaces[%d]", ruleIdx, fromIdx, i)
validation := models.Build("authorizationpolicy.source.namespacenotfound", path)
checks = append(checks, &validation)
}
}
}
return checks, valid
}
func (ap NamespaceMethodChecker) validateToField(ruleIdx int, to []*api_security_v1beta.Rule_To) ([]*models.IstioCheck, bool) {
if len(to) == 0 {
return nil, true
}
checks, valid := make([]*models.IstioCheck, 0, len(to)), true
for toIdx, t := range to {
if t == nil {
continue
}
if t.Operation == nil {
continue
}
if len(t.Operation.Methods) == 0 {
continue
}
for i, m := range t.Operation.Methods {
if !validMethod(m) {
valid = true
path := fmt.Sprintf("spec/rules[%d]/to[%d]/operation/methods[%d]", ruleIdx, toIdx, i)
validation := models.Build("authorizationpolicy.to.wrongmethod", path)
checks = append(checks, &validation)
}
}
}
return checks, valid
}
func validMethod(m string) bool {
valid := false
for _, httpMethod := range httputil.HttpMethods() {
// HTTP methods allowed or
// For gRPC service, a fully-qualified name like “/package.service/method”
valid = valid || (strings.TrimSpace(strings.ToUpper(m)) == httpMethod || methodMatcher.MatchString(m))
}
return valid
}