Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pprof endpoints for debugging perf issues #4597

Closed
nrfox opened this issue Dec 15, 2021 · 2 comments · Fixed by #7105
Closed

Add pprof endpoints for debugging perf issues #4597

nrfox opened this issue Dec 15, 2021 · 2 comments · Fixed by #7105
Assignees
@jmazzitelli
Labels
enhancement This is the preferred way to describe new end-to-end features. requires operator PR It requires update in operator code scalability

Comments

@nrfox
Copy link
Contributor

nrfox commented Dec 15, 2021

Taking inspiration from https://github.com/maxbischoff/kiali/commit/69865f05f7b5247e256b5dc82d145e6bbd708f1f, having pprof endpoints will help in diagnosing perf issues.

The debug handlers can be optionally added at runtime when a config option is enabled, something like config.Server.Debug = true, but disabled by default.
@nrfox nrfox added the enhancement This is the preferred way to describe new end-to-end features. label Dec 15, 2021
@jmazzitelli jmazzitelli self-assigned this Feb 7, 2024
@jmazzitelli
Copy link
Collaborator

jmazzitelli commented Feb 7, 2024 •
edited

I'm going to play with this today to see how easy and un-intrusive we can implement this.

UPDATE: PRs are ready for review:

@jshaughn jshaughn mentioned this issue Feb 7, 2024
Open
7 tasks
@jshaughn
Copy link
Collaborator

jshaughn commented Feb 7, 2024

@hhovsepy , @jmazzitelli I added this to the perf Epic to tie in with our current priorities.

This was referenced Feb 7, 2024
Merged
Merged
@jmazzitelli jmazzitelli added the requires operator PR It requires update in operator code label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmazzitelli jmazzitelli

Labels
enhancement This is the preferred way to describe new end-to-end features. requires operator PR It requires update in operator code scalability
Projects
Kiali Sprint 24-5 | Kiali 1.84
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add profiler to kiali server jmazzitelli/kiali
4 participants
@lucasponce @jmazzitelli @jshaughn @nrfox