Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm] when operator helm chart optionally creates CR, it puts the annotation in the wrong spot #5297

Closed
jmazzitelli opened this issue Jul 9, 2022 · 0 comments · Fixed by kiali/helm-charts#155
Labels
bug Something isn't working enhancement This is the preferred way to describe new end-to-end features.

Comments

@jmazzitelli
Copy link
Collaborator

run this:

$ make build-helm-charts
$ helm install \
   --set cr.create=true \
   --set cr.namespace=istio-system \
   --namespace kiali-operator \
   --create-namespace \
   kiali-operator \
   _output/charts/kiali-operator-*-SNAPSHOT.tgz

and notice the operator verbosity annotation is in the wrong spot - it should be under metadata:

$ kubectl get kiali kiali -n istio-system -o yaml
annotations:
  ansible.sdk.operatorframework.io/verbosity: "1"
apiVersion: kiali.io/v1alpha1
kind: Kiali
metadata:
  annotations:
    meta.helm.sh/release-name: kiali-operator
    meta.helm.sh/release-namespace: kiali-operator
...

Fix the helm template so the annotation is in the correct spot.

While we are at it, allow the user to add their own annotations if needed via --set cr.annotations.NAME=VALUE

@jmazzitelli jmazzitelli added the bug Something isn't working label Jul 9, 2022
@jmazzitelli jmazzitelli added the enhancement This is the preferred way to describe new end-to-end features. label Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement This is the preferred way to describe new end-to-end features.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant