Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong IstioObject field types #6011

Closed
ferhoyos opened this issue Apr 11, 2023 · 2 comments · Fixed by #6258
Closed

Wrong IstioObject field types #6011

ferhoyos opened this issue Apr 11, 2023 · 2 comments · Fixed by #6258
Assignees
Labels
backlog Triaged Issue added to backlog bug Something isn't working

Comments

@ferhoyos
Copy link
Contributor

According to https://kubernetes.io/docs/reference/kubernetes-api/common-definitions/object-meta/, there are some field types wrong in Kubernetes Metadata and OwnerReference interfaces:

export interface K8sMetadata {
name: string;
generateName?: string;
namespace?: string;
selfLink?: string;
uid?: string;
resourceVersion?: string;
generation?: string; --> It is a number
creationTimestamp?: string;
deletionTimestamp?: string;
deletionGracePeriodSeconds?: string; --> It is a number
labels?: { [key: string]: string };
annotations?: { [key: string]: string };
ownerReferences?: K8sOwnerReference[];
initializers?: K8sInitializers[];
finalizers?: string[];
clusterName?: string;
}
export interface K8sOwnerReference {
apiVersion?: string; --> It is required
kind?: string; --> It is required
name?: string; --> It is required
uid?: string; --> It is required
controller?: string;
blockOwnerDeletion?: string;
}

@ferhoyos ferhoyos added the bug Something isn't working label Apr 11, 2023
@jshaughn
Copy link
Collaborator

@ferhoyos Is this something you want added to the backlog?

@ferhoyos ferhoyos added the backlog Triaged Issue added to backlog label May 31, 2023
@ferhoyos
Copy link
Contributor Author

Yes, but with low priority since it does not affect kiali runtime. I had to fix it on the plugin because some dynamic openshift console sdk got in conflict with these interfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Triaged Issue added to backlog bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants