Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multicluster] provide links to external Kialis without requiring istio secrets #6243

Closed
Tracked by #5618
nrfox opened this issue Jun 7, 2023 · 8 comments · Fixed by #6927
Closed
Tracked by #5618

[Multicluster] provide links to external Kialis without requiring istio secrets #6243

nrfox opened this issue Jun 7, 2023 · 8 comments · Fixed by #6927
Assignees
Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features.

Comments

@nrfox
Copy link
Contributor

nrfox commented Jun 7, 2023

Today Kialis in "single cluster" mode require secrets to create links to external kialis. This is effectively putting the Kiali instance in "multi cluster" mode. There needs to be a way to for Kiali to generate links to external Kialis without requiring access to external clusters. This can be a simple as adding a config value that Kiali would use to generate these links. Something like externalKialis: {"name": ..., "url": ...}.

@nrfox nrfox added the enhancement This is the preferred way to describe new end-to-end features. label Jun 7, 2023
@nrfox nrfox mentioned this issue Jun 7, 2023
64 tasks
@jshaughn
Copy link
Collaborator

jshaughn commented Jun 8, 2023

That seems reasonable. Did the former secrets do anything for us other than establish the link? Users would still have to log into the remote Kiali, etc, right?

@jmazzitelli
Copy link
Collaborator

Did the former secrets do anything for us other than establish the link?

AFAIK, that's all the old secrets did for us. It told us the name of the remote cluster and helped us determine the remote kiali URL.

@jshaughn
Copy link
Collaborator

jshaughn commented Jun 8, 2023

So how would we handle the situation that someone was already using the experimental feature and has secrets already, but isn't trying to set up our new MC ability? Just documentation/release notes to delete the secrets and optionally add this proposed config?

@jmazzitelli
Copy link
Collaborator

They still need the istio secrets - those are required for istio MC to work. They just need the kiali secrets so kiali can work.

@nrfox
Copy link
Contributor Author

nrfox commented Dec 6, 2023

This isn't working like I would expect. I want to use this feature for Kiali to show multiple clusters on the "mesh" page without giving access to those clusters. My kiali config in the "east" cluster looks like:

kiali_feature_flags:
  clustering:
    kiali_urls:
      - cluster_name: west
        instance_name: kiali
        namespace: istio-system
        url: kiali-west.io

but still I just see "east"
Screenshot from 2023-12-05 21-01-35

@jmazzitelli
Copy link
Collaborator

I didn't look at any of this but... url: kiali-west.io --- with the name of that config setting as "url" I would expect it to be a URL -- protocol included... http://kiali-west.io -- if this is just a hostname, then we should not be calling this "url".

@hhovsepy
Copy link
Contributor

hhovsepy commented Dec 6, 2023

The url param here expects a protocol as well.

@hhovsepy
Copy link
Contributor

hhovsepy commented Dec 6, 2023

@nrfox right, this feature was implemented partly, I saw your PR, so assigning this to you, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features.
Projects
Development

Successfully merging a pull request may close this issue.

4 participants