Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Typescript version #6267

Closed
Tracked by #6261
ferhoyos opened this issue Jun 17, 2023 · 1 comment · Fixed by #6280
Closed
Tracked by #6261

Upgrade Typescript version #6267

ferhoyos opened this issue Jun 17, 2023 · 1 comment · Fixed by #6280
Assignees
@ferhoyos
Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features. sub-task Ties an issue to an epic

Comments

@ferhoyos
Copy link
Contributor

Since OSSMC uses version 4 of Typescript, it is required to at least upgrade Typescript version of kiali to version 4. If feasible, it would be good to upgrade both to latest Typescript version 5.
@ferhoyos ferhoyos added enhancement This is the preferred way to describe new end-to-end features. backlog Triaged Issue added to backlog sub-task Ties an issue to an epic labels Jun 17, 2023
@ferhoyos ferhoyos mentioned this issue Jun 17, 2023
Closed
12 tasks
@ferhoyos
Copy link
Contributor Author

It seems that CRA does not support Typescript version => 4.7. There are some issues with @typescript-eslint installed by react-scripts.

This is the console warning message when 'yarn lint' is executed:

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <4.7.0

YOUR TYPESCRIPT VERSION: 5.1.3

Please only submit bug reports when using the officially supported version.

=============

For this reason the current highest typescript version that can be used is 4.6.4

@ferhoyos ferhoyos self-assigned this Jun 20, 2023
@ferhoyos ferhoyos mentioned this issue Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferhoyos ferhoyos

Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features. sub-task Ties an issue to an epic
Projects
Kiali Sprint 24-5 | Kiali 1.84
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to typescript version 4 ferhoyos/kiali
1 participant
@ferhoyos