Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s Gateway API - Appenders in Graph #6397

Closed
hhovsepy opened this issue Jul 24, 2023 · 3 comments
Closed

K8s Gateway API - Appenders in Graph #6397

hhovsepy opened this issue Jul 24, 2023 · 3 comments
Assignees
Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features.

Comments

@hhovsepy
Copy link
Contributor

Add detection of Graph appenders for traffic-routing on K8s Gateway and HTTPRoute objects.

@hhovsepy hhovsepy added the enhancement This is the preferred way to describe new end-to-end features. label Jul 24, 2023
@jshaughn
Copy link
Collaborator

jshaughn commented Jul 24, 2023

On istio.io some features now show how to configure it using Istio's Virtual Service AND also K8s Gateway API and HTTPRoute objects. The expectation would be for more and more people to opt for the more standard Gateway API approach. Kiali graph badging needs to take this into account.

I'm not exactly sure how we want to handle things. My first impression is that we can keep the same set of visual badges but that the badge may represent different implementations, and be able to make it clear which are being used. In that way users get a consistent visual experience as they introduce or migrate from VS to K8s GA.

@jshaughn jshaughn added the backlog Triaged Issue added to backlog label Jul 24, 2023
@hhovsepy hhovsepy self-assigned this Jul 24, 2023
@hhovsepy
Copy link
Contributor Author

@jshaughn do you mean this VS bage on 'productpage' Service? It still shows VS badge for HTTPRoute. (In fact for each HTTPRoute a VS is auto-generated, so we need to figure out that.)
Screenshot from 2023-07-27 21-29-03

@jshaughn
Copy link
Collaborator

@hhovsepy Right, this is a good example. My concern here was that we would not detect request routing implemented via HTTPRoute. The basic idea is that when we see an Istio feature that could be implemented via VS or GA, that we can detect it either way. For example, we can still show the same Request Routing badge on the graph, and the side panel should also still show RR information, regardless of whether it is configured by VS or GA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features.
Projects
Development

No branches or pull requests

2 participants