Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider CSS affects Openshift console look and feel (OSSMC plugin) #6417

Closed
Tracked by #6261
ferhoyos opened this issue Jul 26, 2023 · 0 comments · Fixed by #6426
Closed
Tracked by #6261

Slider CSS affects Openshift console look and feel (OSSMC plugin) #6417

ferhoyos opened this issue Jul 26, 2023 · 0 comments · Fixed by #6426
Assignees
Labels
backlog Triaged Issue added to backlog bug Something isn't working sub-task Ties an issue to an epic

Comments

@ferhoyos
Copy link
Contributor

To implement Kiali slider component we are using library bootstrap-slider-without-jquery that uses Bootstrap CSS (Slider/styles/default.css). When Bootstrap CSS is applied in OSSMC plugin gets in conflict with Openshift console (especially in dark mode).

Service view in Openshift console before OSSMC is loaded:
image

Service view in Openshift console after OSSMC is loaded:
image

According to Openshift plugin guidelines (https://docs.openshift.com/container-platform/4.13/web_console/dynamic-plugin/overview-dynamic-plugin.html):

Avoid using other CSS libraries such as Bootstrap or Tailwind. 
They can conflict with PatternFly and will not match the console look and feel.

A solution would be to isolate Bootstrap CSS to affect only OSSMC plugin and not the whole Openshift console.

@ferhoyos ferhoyos added the bug Something isn't working label Jul 26, 2023
@ferhoyos ferhoyos self-assigned this Jul 26, 2023
@ferhoyos ferhoyos added backlog Triaged Issue added to backlog sub-task Ties an issue to an epic labels Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Triaged Issue added to backlog bug Something isn't working sub-task Ties an issue to an epic
Projects
Development

Successfully merging a pull request may close this issue.

1 participant