Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Ambient annotations as configuration settings #6522

Closed
Tracked by #5476
josunect opened this issue Aug 25, 2023 · 0 comments · Fixed by #6627
Closed
Tracked by #5476

Include Ambient annotations as configuration settings #6522

josunect opened this issue Aug 25, 2023 · 0 comments · Fixed by #6627
Assignees
@josunect
Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features. sub-task Ties an issue to an epic

Comments

@josunect
Copy link
Contributor

The same as sidecar annotations, https://github.com/kiali/kiali/blob/master/config/config.go#L235 Ambient annotations should be configurable also.

At the moment, different annotations and labels are used for:

  • Label ambient namespace
  • ztunnel annotation in pods
  • waypoint proxy annotatons

Ref. #5476
@josunect josunect added enhancement This is the preferred way to describe new end-to-end features. sub-task Ties an issue to an epic labels Aug 25, 2023
@josunect josunect mentioned this issue Aug 25, 2023
Open
31 tasks
@jshaughn jshaughn added the backlog Triaged Issue added to backlog label Aug 29, 2023
@josunect josunect self-assigned this Sep 15, 2023
@josunect josunect mentioned this issue Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josunect josunect

Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features. sub-task Ties an issue to an epic
Projects
Kiali Sprint 24-5 | Kiali 1.84
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include Ambient annotations in the config josunect/kiali
2 participants
@jshaughn @josunect