Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workload logs - improve appearance of checkboxes #6811

Closed
nrfox opened this issue Nov 2, 2023 · 3 comments · Fixed by #6904
Closed

Workload logs - improve appearance of checkboxes #6811

nrfox opened this issue Nov 2, 2023 · 3 comments · Fixed by #6904
Assignees
@ferhoyos
Labels
backport completed Issue PRs have been backported backport needed Issue PRs require backport to versions specified in comments enhancement This is the preferred way to describe new end-to-end features.

Comments

@nrfox
Copy link
Contributor

nrfox commented Nov 2, 2023

This might just be personal preference but the appearance of the checkboxes doesn't look great and doesn't fit the style of other checkboxes in the UI:

Screenshot from 2023-11-02 09-07-59

Compare to the metrics page checkboxes:

Screenshot from 2023-11-02 09-10-42

This is probably just a matter of getting rid of the background highlighting.
@nrfox nrfox added the enhancement This is the preferred way to describe new end-to-end features. label Nov 2, 2023
@nrfox
Copy link
Contributor Author

nrfox commented Nov 2, 2023

I haven't looked into what it takes to change this but it's probably simple and this would be a good first issue.

@jshaughn
Copy link
Collaborator

jshaughn commented Nov 2, 2023

It doesn't match the others because it's acting as a legend for the integrated logs. The colors represent the same colors as in the log entry screen. Any alternative would need to solve that issue.

@ferhoyos ferhoyos self-assigned this Dec 1, 2023
@ferhoyos ferhoyos mentioned this issue Dec 1, 2023
Merged
@ferhoyos ferhoyos added the backport needed Issue PRs require backport to versions specified in comments label Dec 21, 2023
@ferhoyos
Copy link
Contributor

Backport needed to 1.73 to improve appearance of checkboxes in OSSMC

@ferhoyos ferhoyos mentioned this issue Jan 2, 2024
Merged
@jshaughn jshaughn added the backport completed Issue PRs have been backported label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferhoyos ferhoyos

Labels
backport completed Issue PRs have been backported backport needed Issue PRs require backport to versions specified in comments enhancement This is the preferred way to describe new end-to-end features.
Projects
Kiali Sprint 24-5 | Kiali 1.84
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve appearance of workload log checkboxes ferhoyos/kiali
3 participants
@jshaughn @nrfox @ferhoyos