Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential runtime error in kube_cache.GetK8sGateways #7006

Closed
hhovsepy opened this issue Jan 5, 2024 · 1 comment
Closed

Potential runtime error in kube_cache.GetK8sGateways #7006

hhovsepy opened this issue Jan 5, 2024 · 1 comment
Assignees
Labels
backlog Triaged Issue added to backlog blocker A bug breaks a fundamental feature. It's critical and it can't be workaround it. bug Something isn't working

Comments

@hhovsepy
Copy link
Contributor

hhovsepy commented Jan 5, 2024

Happens on Kiali master.
Start the Kiali when K8s GW CRDs are not created.
Apply K8s GW CRDs.
Immediately refresh the Kiali page.
Runtime panic nil pointer error in logs, on any of those methods kube_cache.GetK8sGateways.

This is because the userClient.IsGatewayAPI() return 'true' when the CRDs exist, but in fact the k8sgatewayLister was not created while starting the Kiali first time.
https://github.com/kiali/kiali/blob/master/kubernetes/cache/kube_cache.go#L397
Screenshot from 2024-01-05 09-52-45

And any call to k8sgatewayLister causes nil error.
https://github.com/kiali/kiali/blob/master/kubernetes/cache/kube_cache.go#L1504
Screenshot from 2024-01-05 09-55-57

@hhovsepy hhovsepy added bug Something isn't working backlog Triaged Issue added to backlog labels Jan 5, 2024
@hhovsepy hhovsepy changed the title Potential runtie error in kube_cache.GetK8sGateways Potential runtime error in kube_cache.GetK8sGateways Jan 5, 2024
@hhovsepy hhovsepy self-assigned this Jan 5, 2024
@jshaughn jshaughn added the blocker A bug breaks a fundamental feature. It's critical and it can't be workaround it. label Jan 8, 2024
@jshaughn
Copy link
Collaborator

@hhovsepy , I think this issue should have been closed by #7008, no? I'll close, please re-open if I am wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Triaged Issue added to backlog blocker A bug breaks a fundamental feature. It's critical and it can't be workaround it. bug Something isn't working
Projects
Development

No branches or pull requests

2 participants