Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiali operator does not preserve camel case on additional ingress labels #7145

Closed
gurfm opened this issue Feb 21, 2024 · 0 comments · Fixed by kiali/kiali-operator#741
Closed
Assignees
Labels
backport completed Issue PRs have been backported backport needed Issue PRs require backport to versions specified in comments bug Something isn't working requires operator PR It requires update in operator code

Comments

@gurfm
Copy link

gurfm commented Feb 21, 2024

Describe the bug

When adding additional ingress labels in the Kiali CR, such as:

apiVersion: kiali.io/v1alpha1
kind: Kiali
spec:
  deployment:
    ingress:
      additional_labels:
        camelCaseLabel: foo

the label names written in camel case are changed to snake case when propagated by the Kiali operator in the Kiali Route resource:

kind: Route
apiVersion: route.openshift.io/v1
metadata:
  name: kiali
  labels:
    camel_case_label: foo

Expected Behavior

Camel case should be preserved:

kind: Route
apiVersion: route.openshift.io/v1
metadata:
  name: kiali
  labels:
    camelCaseLabel: foo

Environment

We reproduced in Openshift 4.13 with OSSM (Maistra) 2.4 and Kiali 1.65, but from what I can see when looking at the kiali-operator code I believe all versions are impacted.

Proposed fix

Please see PR kiali/kiali-operator#741

@gurfm gurfm added the bug Something isn't working label Feb 21, 2024
@jmazzitelli jmazzitelli added requires operator PR It requires update in operator code backport needed Issue PRs require backport to versions specified in comments labels Feb 21, 2024
@jmazzitelli jmazzitelli added the backport completed Issue PRs have been backported label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport completed Issue PRs have been backported backport needed Issue PRs require backport to versions specified in comments bug Something isn't working requires operator PR It requires update in operator code
Projects
Development

Successfully merging a pull request may close this issue.

2 participants