Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative check added for the Certificates information test #7191

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

matejnesuta
Copy link
Contributor

Issue reference

#7180

@matejnesuta matejnesuta added the test: front-end/cypress PR adds/updates front-end tests (unit and/or cypress automation ) label Mar 13, 2024
@matejnesuta matejnesuta self-assigned this Mar 13, 2024
Comment on lines 17 to 19
if (title === 'Certificates information'){
cy.contains('An error occurred getting certificates information').should('not.exist');
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put this as another step in whatever feature file is testing the certs modal rather than putting a special case in this definition for the Certificates information title.

Something like:

Then user sees the "Certificates information" modal
And there's no error getting certificate information

@matejnesuta matejnesuta requested a review from nrfox March 13, 2024 18:33
@matejnesuta matejnesuta linked an issue Apr 17, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test: front-end/cypress PR adds/updates front-end tests (unit and/or cypress automation )
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

Improve Cypress test related in kiali_help.feature
2 participants