Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iteration over all clusters in workloads/apps/services #7188

Open
nrfox opened this issue Mar 12, 2024 · 2 comments
Open

Remove iteration over all clusters in workloads/apps/services #7188

nrfox opened this issue Mar 12, 2024 · 2 comments
Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features.

Comments

@nrfox
Copy link
Contributor

nrfox commented Mar 12, 2024

What do you want to improve?

Handling of multicluster cluster and namespace checks.

What is the current behavior?

In the business services for workloads/services/apps, Kiali iterates over all clusters and will try to get the cluster namespace depending on whether or not Kiali is a multicluster deployment. This was only added because #5932 has not been resolved and previously requests were made to the backend per namespace. Now with #7076 work they are being made per cluster.

What is the new behavior?

Until #5932 is resolved and the frontend can disambiguate between two namespaces named the same thing on two different clusters, Kiali should instead perform a namespace check if the namespace is passed, otherwise filter out results for inaccessible namespaces. When #5932 is resolved, Kiali can do a namespace check per requested namespace.

@nrfox nrfox added the enhancement This is the preferred way to describe new end-to-end features. label Mar 12, 2024
@hhovsepy
Copy link
Contributor

Seems can be done having in mind already in progress another issue: #4832

@nrfox
Copy link
Contributor Author

nrfox commented Mar 12, 2024

Yes it can be part of or a followup to that work.

@jshaughn jshaughn added the backlog Triaged Issue added to backlog label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features.
Projects
None yet
Development

No branches or pull requests

3 participants