[molecule] flake in molecule test "os-console-links-test"

[jmazzitelli]

Flaky molecule test that has been happening for a few weeks now (I think it was when the tests moved up to openshift 4.14, but I'm not sure).

Solution might be as simple as waiting for Kiali to fully start up and the Kiali operator to finish reconciling with the CR before
the test tries to edit the CR again. That's just a guess. I haven't looked at the test code yet.

....

TASK [Assert that there are no app console links] ******************************
ok: [localhost] => {
    "changed": false,
    "msg": "All assertions passed"
}

TASK [k8s] *********************************************************************
changed: [localhost]

TASK [k8s] *********************************************************************
changed: [localhost]

TASK [k8s] *********************************************************************
changed: [localhost]

TASK [include_tasks] ***********************************************************
included: /tmp/molecule/operator/molecule/os-console-links-test/../common/../common/wait_for_kiali_cr_changes.yml for localhost

TASK [Wait for Kiali CR changes to take effect] ********************************
ok: [localhost]

TASK [Set accessible namespace to ['istio-system', 'consolelinks1', 'consolelinks2'] in current Kiali CR] ***
ok: [localhost]

TASK [include_tasks] ***********************************************************
included: /tmp/molecule/operator/molecule/os-console-links-test/../common/../common/set_kiali_cr.yml for localhost

TASK [Change Kiali CR with new Kiali CR] ***************************************
fatal: [localhost]: FAILED! => {"changed": false, "error": 409, "msg": "Failed to patch object: b'{\"kind\":\"Status\",\"apiVersion\":\"v1\",\"metadata\":{},\"status\":\"Failure\",\"message\":\"Operation cannot be fulfilled on kialis.kiali.io \\\\\"kiali\\\\\": the object has been modified; please apply your changes to the latest version and try again\",\"reason\":\"Conflict\",\"details\":{\"name\":\"kiali\",\"group\":\"kiali.io\",\"kind\":\"kialis\"},\"code\":409}\\n'", "reason": "Conflict", "status": 409}

[nrfox]

This is a normal error that occurs when:
(RV == Resource Version)

kiali CR: RV1 - You read the obj
kiali CR: RV2 - Something else updates the obj
kiali CR: RV1 - You submit an update with the kaili CR at RV1

You just need to re-read the latest version of the object and resubmit the update.

[jmazzitelli]

This is a normal error that occurs when:

Right - the question is why is the Kiali CR changing when it wasn't expected. I'm looking into this. I think it has to do with the fact this test adds namespaces and the operator might be changing the CR when it detects new namespaces.

[nrfox]

Right - the question is why is the Kiali CR changing when it wasn't expected.

If even the status of the Kiali CR has changed then iirc resource version will also get updated.