Swift 2 updated #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -160,7 +161,7 @@ public extension MKAnnotationView { | |||
| } | |||
| } | |||
|
|
|||
| dataTask.resume() | |||
| dataTask?.resume() | |||
There was a problem hiding this comment.
I'm getting errors here with beta 4. "Cannot use optional chaining on non-optional value of type 'NSURLSessionDataTask'"
|
Xcode 7 is going to be released soon, and while your project looks oustanding, it won't compile (as noted before). @kiavashfaisali Will you consider having a Swift 2.0 branch that we can use? |
|
@kbpontius I will be moving the code base to Swift 2.0 within a couple of days of Xcode 7 reaching GM. In the future I'll have branches for BETA Swift or Xcode versions so as to not block others from contributing on BETA versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just made a few updates in the code based on swift2
I know you will note merge this into master. Please, create a new branch for swiftv2 and I'll create a new pull request.