Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

checklib.py is not running when called from comparelibs.py #70

Closed
marsfan opened this issue Dec 13, 2016 · 7 comments
Closed

checklib.py is not running when called from comparelibs.py #70

marsfan opened this issue Dec 13, 2016 · 7 comments

Comments

@marsfan
Copy link

marsfan commented Dec 13, 2016

The title pretty much sums it up. I don't think I am calling anything wrong. I need this feature to work to get some continuous integration code I am using to work.

@SchrodingersGat
Copy link
Contributor

Can you provide any more info?

@marsfan
Copy link
Author

marsfan commented Dec 14, 2016

@SchrodingersGat I called the function on bash as python3 comparelibs.py --check --new [path-to-new] --original [path to original]. The call properly returned the added/changed/removed parts, but instead of checking the added/changed parts, it simply returned the name of the part and the library directory.

Here is the execution:

USER@USER_COMPUTER:/mnt/c/Users/USER/kicad-library-utils/schlib$ python3 comparelibs.py --check --original /mnt/c/Users/
USER/kicad-library/library/switches.lib --new /mnt/c/Program\ Files/KiCad/share/kicad/kicad-library/library/switches.lib

+ testingapart
USER@USER_COMPUTER:/mnt/c/Users/USER/kicad-library-utils/schlib$

I ran this on bash for Ubuntu for windows. I do not have access to a Linux machine and I am not good with the windows command line.

@SchrodingersGat
Copy link
Contributor

Ok I've found the error and submitted a PR here: #75

Thanks for finding this.

@marsfan
Copy link
Author

marsfan commented Dec 28, 2016

@SchrodingersGat Thanks. As soon as this PR is merged I will get back to working on my automation script to identify errors in submitted parts.

@SchrodingersGat
Copy link
Contributor

Great, keep us posted :) I look forward to seeing what you come up with, and am happy to provide any assistance.

@SchrodingersGat
Copy link
Contributor

#75 has merged - you're good to go

@marsfan
Copy link
Author

marsfan commented Feb 13, 2017

Booyah. Auto checking, here I come

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants