Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check and enhance Tokens for inverted style #16

Open
DanielLeyUX opened this issue Sep 22, 2023 · 3 comments
Open

Check and enhance Tokens for inverted style #16

DanielLeyUX opened this issue Sep 22, 2023 · 3 comments
Assignees
@fleven-kds
Labels
enhancement New feature or request
Milestone
Release 09/2023

Comments

@DanielLeyUX
Copy link

the inverted token set needs to be improved.

e.g. subheadline in inverted accent section is white on white
@DanielLeyUX DanielLeyUX added the enhancement New feature or request label Sep 22, 2023
@DanielLeyUX DanielLeyUX added this to the Release 09/2023 milestone Sep 22, 2023
@julrich
Copy link
Member

julrich commented Jan 4, 2024

Blatant errors should be fixed now, but overall it still feels a bit lacking. Especially when viewed in the context of a page where an inverted Section will live next to a non-inverted Section. The result still feels quite jarring, maybe a shade of grey that's a bit darker could already help here.

e.g.:
image

@julrich
Copy link
Member

julrich commented Jan 18, 2024

Possibly related: kickstartDS/kickstartDS#1535

@julrich
Copy link
Member

julrich commented Jan 18, 2024

Maybe related:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fleven-kds fleven-kds

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release 09/2023
Development

No branches or pull requests
3 participants
@julrich @fleven-kds @DanielLeyUX