Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of Components featuring Button Group Provider #42

Open
fleven-kds opened this issue Dec 13, 2023 · 1 comment
Open

List of Components featuring Button Group Provider #42

fleven-kds opened this issue Dec 13, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@fleven-kds
Copy link
Collaborator

fleven-kds commented Dec 13, 2023

List of Components featuring a ButtonGroup through the use of a ButtonContextProvider:

  • VideoCurtain (Based on KdsVisual)
  • Hero (Based on KdsVisual)
  • ImageStory (based on KdsStorytelling)
  • CtaPaid (based on KdsStorytelling)

The current approach of integrating a ButtonGroup into components via ButtonContextProvider is not optimal. It would be more efficient and maintainable to find an alternative method for this integration. One potential solution could be to natively integrate them into the base kickstartDS components (Visual & Storytelling).

@fleven-kds fleven-kds added the enhancement New feature or request label Dec 13, 2023
@julrich
Copy link
Member

julrich commented Dec 13, 2023

Somehow thought we'd have a ticket for this already... but was only able to come up with this one for our own, branded instance: kickstartDS/kickstartDS-storybook#5

We should do this in kickstartDS/content, though. Directly changing how Storytelling and Visual work at the source. We already have won a ButtonGroup component in the meantime, which should be used in those components:
https://github.com/kickstartDS/kickstartDS/blob/next/packages/components/base/source/button-group/ButtonGroupComponent.tsx

@julrich julrich added this to the Release 09/2023 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants