New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar shadow disappears sometimes #65

Closed

AllanWang opened this issue Mar 4, 2017 · 1 comment

AllanWang commented Mar 4, 2017

If you scroll very quickly and very far down, the shadow will disappear. Scrolling back up will make it appear again. Is this intended behaviour?

Contributor

luoser commented Mar 20, 2017

Ah, a subtle catch--looks like this is because the sort tab inherits its 4dp elevation from its parent CoordinatorLayout while the discovery toolbar (the navy blue) has no elevation since we would not want the top toolbar's shadow to render onto the sort tab bar.

If you've got a suggestion for how to render this shadow only when the tab layout is hidden we'd welcome a PR!

luoser closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment