Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML to JSON conversion unnecessary and broken #25

Open
doismellburning opened this issue Nov 2, 2016 · 1 comment
Open

YAML to JSON conversion unnecessary and broken #25

doismellburning opened this issue Nov 2, 2016 · 1 comment

Comments

@doismellburning
Copy link

CloudFormation now supports YAML templates natively, rendering cfn-flow's "converts from YAML to JSON" obsolete

In addition, CloudFormation Intrinsic Functions have a YAML "short form" (e.g. !GetAtt foo.bar) that cfn-flow naïvely transforms to JSON, turning a valid CF YAML template into invalid CF JSON

(If you confine yourself to the "long form" of the functions, it's fine)

@ktheory
Copy link
Contributor

ktheory commented Nov 2, 2016

@doismellburning Yup! Totally correct. I'd welcome a PR to removes the conversion to JSON.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants