-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any plan to upgrade to Swift 3? #14
Comments
Yeah for sure! It'll probably be the first thing we do in the new year. Stay tuned for the massive PR... |
@mbrandonw so, will you be doing the migration in-house and without involving open-source community? |
@evgeniyd We'll be doing the migration in the open on branches and definitely won't turn down community help! 😄 |
I would love to give a hand. This project is such an amazing resource. |
Great to hear that @evgeniyd Like @damianesteban I'd love to help in this project! |
Volunteering to help out over here 👋 |
Hi everyone! We've begun the Swift 3 migration, and it's doozy! We don't see a clear way of sharing this work, but if yer interested in following along or critiquing our methods, here are some PR's we've done so far: kickstarter/Kickstarter-Prelude#62 |
Hey @mbrandonw I've migrated several ~900 class Swift projects to Swift 3 in the last month or so, (also the author of https://buildingvts.com/a-mostly-comprehensive-list-of-swift-3-0-and-2-3-changes-193b904bb5b1) I'd like to share lessons learned doing these large migrations:
return String(data: deviceToken.base64EncodedData(), encoding: .utf8)?
.trimmingCharacters(in: CharacterSet.whitespaces)
.trimmingCharacters(in: CharacterSet(charactersIn: "<>"))
?? "" Realistically, the right way is to treat PN deviceTokens as
Finally, FREEZE THE WORLD. Conflicts here are neither trivial or fun. Don't spend time trying to deal with them. |
@heshamsalman wow, thanks for all of the info! definitely the we just opened a PR that converts our |
oh, and btw @heshamsalman, this is how we do our push token transformation: https://github.com/kickstarter/ios-oss/blob/master/Kickstarter-iOS/ViewModels/AppDelegateViewModel.swift#L629-L634. That's swift 2 code, hasn't been updated to swift 3 yet. i'll keep your comments in mind when i get to that code! thanks again! |
Hey everyone, we just completed our Swift 3 migration #26 so I'll close this one now. Thanks for the interest! |
Swift 2.3 would be deprecated in the next release of Xcode. Do you have any plan to upgrade the entire code base and dependencies?
The text was updated successfully, but these errors were encountered: