Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_gfs_with_extra_contributors accesses keys that aren't used #6

Closed
fiendish opened this issue Oct 28, 2019 · 0 comments · Fixed by #7
Closed

find_gfs_with_extra_contributors accesses keys that aren't used #6

fiendish opened this issue Oct 28, 2019 · 0 comments · Fixed by #7
Labels
bug Something isn't working

Comments

@fiendish
Copy link
Contributor

fiendish commented Oct 28, 2019

Describe the bug
find_gfs_with_extra_contributors accesses keys that aren't used causing errors

has_extra_contributors = {
"mixed_visibility": set(),
"hidden": set(),
"visible": set(),
}

vs

has_extra_contributors["all_hidden"].add(g)
else:
has_extra_contributors["all_visible"].add(g)

and
descendant_kfids["genomic-files"] -= extra_contrib_gfs["all_hidden"]

@fiendish fiendish added the bug Something isn't working label Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant