[JBPM-9520] KafkaServerExtension poll is not freed #2342
Conversation
fjtirado
force-pushed
the
JBPM-9520
branch
8 times, most recently
from
f836b0f
to
b51199c
Compare
|
jenkins retest this |
|
jenkins test this |
Changing lock policy
| if (processMessages()) { | ||
| removeTopics(topic2Message, deploymentId, processDefinition.getMessagesDesc()); | ||
| } | ||
| removeTopics(topic2Signal, deploymentId, processDefinition.getSignalsDesc()); |
There was a problem hiding this comment.
This change tries to cover an edge case. System property enable when onDeploy/onActivate is called, but disable when onUndeploy/onDeactivate is invoked. This will leak to a subscripton "leak". In order to avoid that, at the cost of sacrificing a bit of performance (not much in any case), it is better to clean always
There was a problem hiding this comment.
OK, agreed; it's very weird but not impossible. Anyway, performance impact is minimum and removing topics is during undeployment.
|
Jenkins retest this |
1 similar comment
|
Jenkins retest this |
|
jenkins test this (and do not fail with gitub login if possible ;)) |
|
jenkins test this |
| if (processMessages()) { | ||
| removeTopics(topic2Message, deploymentId, processDefinition.getMessagesDesc()); | ||
| } | ||
| removeTopics(topic2Signal, deploymentId, processDefinition.getSignalsDesc()); |
There was a problem hiding this comment.
OK, agreed; it's very weird but not impossible. Anyway, performance impact is minimum and removing topics is during undeployment.
|
jenkins test this |
|
Kudos, SonarCloud Quality Gate passed! |
Using read write lock
JIRA:
JBPM-9520