[JBPM-9961] Process with multiple timer startNodes only triggers one #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmunozfe
suggested changes
Dec 16, 2021
elguardian
force-pushed
the
JBPM-9961
branch
from
5e8f998
to
006779d
Compare
gmunozfe
approved these changes
Dec 17, 2021
There was a problem hiding this comment.
Looks good to me, just a minor comment in the test about timeout, perfectly done @elguardian !
| @@ -192,4 +195,31 @@ public void testDelayingTimerStartEvent() throws Exception { | |||
| process.clear(); | |||
| } | |||
|
|
|||
| @Test(timeout=100000000) | |||
There was a problem hiding this comment.
Why so long? probably 10-30 seconds is enough, wdyt?
elguardian
force-pushed
the
JBPM-9961
branch
from
006779d
to
df8f4c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/JBPM-9961