Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome Extensions are not working with GitHub's "New Code Search and Code View" #247

Closed
ljmotta opened this issue May 3, 2023 · 4 comments
Labels
area:tools Issues affecting KIE Tools type:enhancement Something that already exists needs to be improved

Comments

@ljmotta
Copy link

ljmotta commented May 3, 2023

GitHub Feature Preview "New Code Search and Code View" changes their UI significantly, making our query selectors obsoletes. The View and Edit pages are not loading the extension and the Editors.

Images

Project view (works)

image

View BPMN (not working)

image

Edit BPMN (not working)

image

View DMN (not working)

image

Edit DMN (not working)

image

PR (works)

image

Code

The query selectors are located in the packages/chrome-extension/src/app/Dependecies.ts file.

### Acceptance criteria
- [ ] The BPMN and DMN Editors should render in `readonly` mode in the View page;
- [ ] The BPMN and DMN Editors should render and properly work in the Edit page;
@ljmotta ljmotta changed the title The Chrome Extension is not properly working in the View and Edit pages after an UI update The Chrome Extension is not properly working with the "New Code Search and Code View" GitHub Feature Preview May 4, 2023
@ljmotta ljmotta added type:enhancement Something that already exists needs to be improved area:tools Issues affecting KIE Tools labels May 4, 2023
@thiagoelg
Copy link
Member

Seems like this is not a Feature Preview anymore and was rolled out to all users (https://github.blog/changelog/2023-05-08-the-new-code-search-and-code-view-is-now-generally-available/)

@tiagobento tiagobento changed the title The Chrome Extension is not properly working with the "New Code Search and Code View" GitHub Feature Preview Chrome Extensions are not working with GitHub's "New Code Search and Code View" Jun 7, 2023
@tiagobento
Copy link

Looks like there's working being done here: https://github.com/kiegroup/kie-tools/pull/1720

@thiagoelg
Copy link
Member

The new code view is enabled for anonymous users as well, breaking our CI: https://github.blog/changelog/2023-07-06-anonymous-users-have-access-to-new-code-view-and-navigation/

Disabling tests for now: kiegroup/kie-tools@fd88d5f

@ljmotta
Copy link
Author

ljmotta commented Jul 19, 2023

@ljmotta ljmotta closed this as completed Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tools Issues affecting KIE Tools type:enhancement Something that already exists needs to be improved
Projects
None yet
Development

No branches or pull requests

3 participants