Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEEL function split(string, delimiter, flags) should be removed from the DMN engine #364

Closed
yesamer opened this issue Jun 22, 2023 · 2 comments · Fixed by apache/incubator-kie-drools#5465
Closed

FEEL function split(string, delimiter, flags) should be removed from the DMN engine #364

yesamer opened this issue Jun 22, 2023 · 2 comments · Fixed by apache/incubator-kie-drools#5465
Assignees
@jomarko
Labels
area:dmn Related to DMN area:engine Related to the runtime engines type:enhancement Something that already exists needs to be improved

Comments

@yesamer
Copy link

yesamer commented Jun 22, 2023

Here, a FEEL function split(string, delimiter, flags) is defined, even if not part of DMN 1.4 specs.
As a result of this conversion, It should be removed keeping the split(string, delimiter) function only
@yesamer yesamer added type:enhancement Something that already exists needs to be improved area:dmn Related to DMN area:engine Related to the runtime engines labels Jun 22, 2023
@jomarko
Copy link

jomarko commented Jun 26, 2023

isn't this completed as part of https://github.com/kiegroup/kie-tools/pull/1757/files ?

@yesamer
Copy link
Author

yesamer commented Jun 26, 2023

@jomarko No, the scope of this ticket is to remove it from the engine, as not part of the specs.
//cc @baldimir

@tiagobento tiagobento self-assigned this Aug 14, 2023
jomarko added a commit to jomarko/drools that referenced this issue Aug 16, 2023
@jomarko
kie-issues#364: DMN FEEL function split(string, delimiter, flags) sho…
0be537b 
…uld be removed

Closes: apache/incubator-kie-issues#364
@jomarko jomarko assigned jomarko and unassigned tiagobento Aug 16, 2023
@jomarko jomarko mentioned this issue Aug 16, 2023
Merged
jomarko added a commit to jomarko/drools that referenced this issue Aug 16, 2023
@jomarko
kie-issues#364: DMN FEEL function split(string, delimiter, flags) sho…
f6ee100 
…uld be removed

Closes: apache/incubator-kie-issues#364
@tiagobento tiagobento mentioned this issue Aug 18, 2023
Closed
13 tasks
@tiagobento tiagobento changed the title DMN FEEL function split(string, delimiter, flags) should be removed FEEL function split(string, delimiter, flags) should be removed from the DMN engine Aug 18, 2023
jomarko added a commit to jomarko/drools that referenced this issue Aug 21, 2023
@jomarko
kie-issues#364: DMN FEEL function split(string, delimiter, flags) sho…
7f2b2f7 
…uld be removed

Closes: apache/incubator-kie-issues#364
jomarko added a commit to jomarko/drools that referenced this issue Aug 25, 2023
@jomarko
kie-issues#364: DMN FEEL function split(string, delimiter, flags) sho…
9258292 
…uld be removed

Closes: apache/incubator-kie-issues#364
jomarko added a commit to jomarko/drools that referenced this issue Aug 30, 2023
@jomarko
kie-issues#364: DMN FEEL function split(string, delimiter, flags) sho…
befc3d0 
…uld be removed

Closes: apache/incubator-kie-issues#364
jomarko added a commit to jomarko/drools that referenced this issue Aug 31, 2023
@jomarko
kie-issues#364: DMN FEEL function split(string, delimiter, flags) sho…
c1a1c11 
…uld be removed

Closes: apache/incubator-kie-issues#364

Update kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/SplitFunction.java

Co-authored-by: Matteo Mortari <matteo.mortari@gmail.com>

Fix imports
tarilabs pushed a commit to apache/incubator-kie-drools that referenced this issue Sep 1, 2023
@jomarko
kie-issues#364: DMN FEEL function split(string, delimiter, flags) sho…
7e30030 
…uld be removed (#5465)

Closes: apache/incubator-kie-issues#364

Update kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/SplitFunction.java

Co-authored-by: Matteo Mortari <matteo.mortari@gmail.com>

Fix imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jomarko jomarko

Labels
area:dmn Related to DMN area:engine Related to the runtime engines type:enhancement Something that already exists needs to be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kie-issues#364: DMN FEEL function split(string, delimiter, flags) sho… jomarko/drools
3 participants
@tiagobento @jomarko @yesamer