[7.11.x] added new groovy script #345
Conversation
(cherry picked from commit 3003755)
|
Looks ok, but agree with @pszubiak that if there is a similar code, it should be refactored, because duplicate code is a pain to maintain. |
| "optaplanner-wb" : [], | ||
| "jbpm-designer" : [], | ||
| "jbpm-wb" : [] | ||
| //"kie-wb-distributions" : [] // kie-wb-distributions is the last repo in the chain |
There was a problem hiding this comment.
Just out of curiosity, why is kie-wb-distributions commented out?
There was a problem hiding this comment.
@winklerm good question - this was taken 1:1 from Petr - so we did not change it. There should be no other rep dependent of kie-wb-distributions? (like droolsjbpm-tools)
There was a problem hiding this comment.
@winklerm To add my understanding: I believe it's ok to have kie-wb-distributions and droolsjbpm-tools commented out.
The purpose of this groovy script is to generate "compile downstream" jobs is to make sure that changes in repo X don't break any of the repos that depend on X. In this particualr case there are no repos that depend on kie-wb-distributions and on droolsjbpm-tools, so we don't need jobs for those.
| "**/target/kie-wb*eap*.war", | ||
| "**/target/kie-drools-wb*wildfly*.war", | ||
| "**/target/kie-drools-wb*eap*.war", | ||
| "**/target/kie-server-*ee6.war", |
There was a problem hiding this comment.
@mbiarnes you told me that kie-server ee6 is no longer being generated, so it should probably be removed from this "what to archive" section.
| label : "kie-rhel7 && kie-mem8g", | ||
| ghAuthTokenId : Constants.GITHUB_AUTH_TOKEN, | ||
| upstreamMvnArgs : "-B -e -T1C -DskipTests -Dgwt.compiler.skip=true -Dgwt.skipCompilation=true -Denforcer.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true -Drevapi.skip=true clean install", | ||
| downstreamMvnGoals : "-B -e -nsu -fae clean install -Dfull=true -DskipTests -Dgwt.compiler.skip=true -Dgwt.skipCompilation=true", |
There was a problem hiding this comment.
Since we won't be running any tests in these "just compile" jobs, I would suggest adding -T1C into the downstreamMvnGoals - here maven parallelism shouldn't hurt, on the contrary it will make the jobs run faster.
There was a problem hiding this comment.
+1; adding -T1C seems to be a very good idea.
There was a problem hiding this comment.
@mbiarnes @baldimir I'm fine with merging it "as is" and refactor later.
My other concern is that these two PRs will increase usage of GitHub PR builder plug-in by ~50%. My impression is that the more we use ghpr plug-in the more often Jenkins hangs due to bug identified in it (JENKINS-19123).
Wonder if it makes sense to run these jobs on kie-jenkins until ghpr plug-in issue is solved? Doing that we provide even more chaos but we are limiting the negative impact of this new jobs on normal downstream and PRs jobs. What do you think?
| label : "kie-rhel7 && kie-mem8g", | ||
| ghAuthTokenId : Constants.GITHUB_AUTH_TOKEN, | ||
| upstreamMvnArgs : "-B -e -T1C -DskipTests -Dgwt.compiler.skip=true -Dgwt.skipCompilation=true -Denforcer.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true -Drevapi.skip=true clean install", | ||
| downstreamMvnGoals : "-B -e -nsu -fae clean install -Dfull=true -DskipTests -Dgwt.compiler.skip=true -Dgwt.skipCompilation=true", |
There was a problem hiding this comment.
+1; adding -T1C seems to be a very good idea.
|
@jhrcek Yes, that's the idea. Once the issue with ghpr plug-in is solved it will land on rhba-jenkins. The new functionality first will be introduced for the master branch and if everything is fine then support for 7.11.x will be added. |
(cherry picked from commit 3003755)
for the compilation of all downstream reps skipping tests and skipping gwt compilation