Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DROOLS-4165: [DMN Designer] BKM Function column width #2698

Merged
merged 1 commit into from Jun 18, 2019
Merged

DROOLS-4165: [DMN Designer] BKM Function column width #2698

merged 1 commit into from Jun 18, 2019

Conversation

manstis
Copy link
Member

@manstis manstis commented Jun 12, 2019

See https://issues.jboss.org/browse/DROOLS-4165

This PR ensures the column widths of a Function within a BKM are written to and read from the XML file.

@manstis manstis requested review from karreiro and jomarko June 12, 2019 13:33
jomarko
jomarko approved these changes Jun 13, 2019
View reviewed changes
Copy link

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@manstis
Copy link
Member Author

manstis commented Jun 13, 2019

Jenkins please retest this.

2 similar comments
@manstis
Copy link
Member Author

manstis commented Jun 13, 2019

Jenkins please retest this.

@manstis
Copy link
Member Author

manstis commented Jun 14, 2019

Jenkins please retest this.

karreiro
karreiro approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @manstis.

@cristianonicolai
Copy link
Contributor

jenkins please retest this

@manstis manstis merged commit ab0ae03 into kiegroup:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karreiro karreiro karreiro approved these changes

@jomarko jomarko jomarko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@manstis @cristianonicolai @karreiro @jomarko