This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
[KOGITO-850] Add Cucumber test for Prometheus integration #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardozanini
suggested changes
Jan 9, 2020
test/smoke/openshift.go
Outdated
| @@ -133,3 +156,34 @@ func waitAndRetrieveRouteURI(namespace, serviceName string) (string, error) { | |||
| GetLogger(namespace).Debugf("Got route %s\n", routeURI) | |||
| return routeURI, nil | |||
| } | |||
|
|
|||
| // waitForPods waits for pods with specific label to be available and running | |||
| func waitForPods(namespace, labelName, labelValue string, numberOfPods, timeoutInMin int) error { | |||
There was a problem hiding this comment.
Since those functions are related to Pods resource, why not keep them on kubernetes.go instead?
There was a problem hiding this comment.
good point, can do that in next PR, can move there also route functions
sutaakar
changed the title
|
@ricardozanini Good point, added JIRA for this test. |
Signed-off-by: Karel Suta <ksuta@redhat.com>
|
@ricardozanini Can you please take a look again? |
ricardozanini
approved these changes
Jan 10, 2020
ricardozanini
added
ready 🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/KOGITO-850
Signed-off-by: Karel Suta ksuta@redhat.com
Many thanks for submiting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
[KOGITO-XYZ] Subject