This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
[KOGITO-1396] Adjustments for 0.8.0 release #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardozanini
requested review from
spolti,
sutaakar,
radtriste,
sterobin and
xieshenzh
xieshenzh
approved these changes
Mar 10, 2020
radtriste
approved these changes
Mar 11, 2020
| # httpPort: 8080 | ||
| # details about the kafka connection | ||
| kafka: | ||
| # let's leave this burden to KogitoInfra CR to deploy a new Kafka instance for us | ||
| useKogitoInfra: true | ||
| useKogitoInfra: false |
There was a problem hiding this comment.
why did you switch to false here ?
dataindex will need kafka and infinispan or ?
There was a problem hiding this comment.
Because of the CI on OperatorHub. Since they don't implement the dependency management there, the Data Index will fail to deploy and will fail the PR
There was a problem hiding this comment.
Although I'll work on this for the next version. The Operator will handle with this kind of failures and will have a nice status message.
sutaakar
approved these changes
Mar 11, 2020
spolti
approved these changes
Mar 11, 2020
|
OperatorHub PR: operator-framework/community-operators#1325 |
MarianMacik
approved these changes
Mar 11, 2020
ricardozanini
force-pushed
the
kogito-1396
branch
from
11d6922
to
319d264
Compare
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
ricardozanini
force-pushed
the
kogito-1396
branch
from
319d264
to
8ded4e6
Compare
ricardozanini
changed the title
MarianMacik
approved these changes
Mar 12, 2020
|
OperatorHub PR merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
https://issues.redhat.com/browse/KOGITO-1396
This commit contains small adjustments for the OperatorHub PR.
Many thanks for submiting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
[KOGITO-XYZ] Subject