Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

[KOGITO-1919] - Allow user to specify the artifact and group id when … #356

Merged
merged 10 commits into from
May 28, 2020
Merged

[KOGITO-1919] - Allow user to specify the artifact and group id when … #356

merged 10 commits into from
May 28, 2020

Conversation

vaibhavjainwiz
Copy link
Contributor

@vaibhavjainwiz vaibhavjainwiz commented May 26, 2020 •
edited

…doing builds from archetype

Jira Issue : https://issues.redhat.com/browse/KOGITO-1919

Many thanks for submiting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request title is properly formatted: [KOGITO-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a unit test that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster

@vaibhavjainwiz vaibhavjainwiz added the needs review 🔍 Pull Request that needs reviewers label May 26, 2020
@spolti spolti added this to the v0.11.0 milestone May 26, 2020
@spolti
Copy link
Member

spolti commented May 26, 2020

@vaibhavjainwiz could you please check the errors? Both jobs are failing.

ricardozanini
ricardozanini suggested changes May 26, 2020
View reviewed changes
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just minor comments.

cmd/kogito/command/deploy/deploy_service_test.go Outdated Show resolved Hide resolved
cmd/kogito/command/deploy/deploy_service_test.go Outdated Show resolved Hide resolved
pkg/apis/app/v1alpha1/kogitoapp_types.go Show resolved Hide resolved
pkg/apis/app/v1alpha1/kogitoservices_types.go Show resolved Hide resolved
pkg/controller/kogitoapp/resource/build_config_s2i.go Outdated Show resolved Hide resolved
test/framework/openshift.go Show resolved Hide resolved
@radtriste
Copy link
Contributor

depends on https://github.com/kiegroup/kogito-images/pull/164

radtriste
radtriste suggested changes May 26, 2020
View reviewed changes
cmd/kogito/command/deploy/deploy_service.go Outdated Show resolved Hide resolved
pkg/apis/app/v1alpha1/kogitoapp_types.go Outdated Show resolved Hide resolved
pkg/controller/kogitoapp/resource/build_config_s2i.go Outdated Show resolved Hide resolved
test/framework/openshift.go Show resolved Hide resolved
radtriste
radtriste approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@radtriste radtriste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ricardozanini
ricardozanini approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing that was left over. I think I was not clear enough in the last review, my bad. I'm sorry.

@spolti spolti merged commit fcc4322 into apache:master May 28, 2020
@vaibhavjainwiz vaibhavjainwiz deleted the KOGITO-1919 branch June 30, 2020 06:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

@sutaakar sutaakar sutaakar approved these changes

@spolti spolti spolti approved these changes

@radtriste radtriste radtriste approved these changes

Assignees

@spolti spolti

Labels
needs review 🔍 Pull Request that needs reviewers
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vaibhavjainwiz @spolti @radtriste @ricardozanini @sutaakar