Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

[KOGITO-1957][KOGITO-2359] Setup a specific repository on local maven & S2I builds #369

Merged
merged 1 commit into from
Jun 22, 2020
Merged

[KOGITO-1957][KOGITO-2359] Setup a specific repository on local maven & S2I builds #369

merged 1 commit into from
Jun 22, 2020

Conversation

radtriste
Copy link
Contributor

@radtriste radtriste commented Jun 2, 2020 •
edited

https://issues.redhat.com/browse/KOGITO-1957
https://issues.redhat.com/browse/KOGITO-2359

Many thanks for submiting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request title is properly formatted: [KOGITO-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a unit test that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster

@radtriste radtriste force-pushed the kogito-1957 branch 7 times, most recently from f77db84 to 5584b32 Compare June 8, 2020 08:08
@radtriste radtriste changed the title [KOGITO-1957] Setup a specific repository on local maven & S2I builds [KOGITO-1957][KOGITO-2359] Setup a specific repository on local maven & S2I builds Jun 8, 2020
@radtriste radtriste force-pushed the kogito-1957 branch 7 times, most recently from 438bf8f to 1aacdd8 Compare June 11, 2020 16:59
@ricardozanini ricardozanini added this to the v0.12.0 milestone Jun 16, 2020
@radtriste radtriste force-pushed the kogito-1957 branch 3 times, most recently from 5444169 to f0060b1 Compare June 17, 2020 14:28
@spolti spolti added the WIP 👷‍♂️ Pull Request is on work in progress label Jun 17, 2020
@radtriste radtriste added on hold ✋ Pull Request is waiting for other dependencies and removed WIP 👷‍♂️ Pull Request is on work in progress labels Jun 18, 2020
@radtriste radtriste marked this pull request as ready for review June 18, 2020 09:51
@radtriste
Copy link
Contributor Author

Waiting for #386 to be merged first

@radtriste radtriste marked this pull request as draft June 18, 2020 09:51
@radtriste radtriste added needs review 🔍 Pull Request that needs reviewers and removed on hold ✋ Pull Request is waiting for other dependencies labels Jun 19, 2020
@radtriste
Copy link
Contributor Author

no need to wait for #386 anymore

@radtriste radtriste marked this pull request as ready for review June 19, 2020 08:30
@radtriste radtriste requested review from sutaakar and Sgitario and removed request for ricardozanini and vaibhavjainwiz June 19, 2020 10:32
@radtriste
Copy link
Contributor Author

Linux check is the new RHBA check still in test and can be ignored

@radtriste radtriste removed the request for review from spolti June 19, 2020 10:47
Sgitario
Sgitario approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@Sgitario Sgitario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just minor things.

test/framework/maven.go Show resolved Hide resolved
test/steps/maven.go Show resolved Hide resolved
test/steps/maven.go Show resolved Hide resolved
@radtriste radtriste merged commit 82aee4a into apache:master Jun 22, 2020
@radtriste radtriste deleted the kogito-1957 branch June 22, 2020 08:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sgitario Sgitario Sgitario approved these changes

@sutaakar sutaakar sutaakar approved these changes

@Kaitou786 Kaitou786 Kaitou786 approved these changes

Assignees
No one assigned
Labels
needs review 🔍 Pull Request that needs reviewers
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@radtriste @sutaakar @Sgitario @Kaitou786 @ricardozanini @spolti