Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

[KOGITO-2351] - Integrate golint with PR checks on kogito-cloud-opera… #371

Merged
merged 1 commit into from
Jun 4, 2020
Merged

[KOGITO-2351] - Integrate golint with PR checks on kogito-cloud-opera… #371

merged 1 commit into from
Jun 4, 2020

Conversation

Kaitou786
Copy link
Contributor

@Kaitou786 Kaitou786 commented Jun 4, 2020 •
edited

…tor repository

See: https://issues.redhat.com/browse/KOGITO-2351

Signed-off-by: Tarun Khandelwal tarkhand@redhat.com

Many thanks for submiting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request title is properly formatted: [KOGITO-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a unit test that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster

@Kaitou786 Kaitou786 added the needs review 🔍 Pull Request that needs reviewers label Jun 4, 2020
@Kaitou786 Kaitou786 force-pushed the KOGITO-2351 branch 3 times, most recently from e450caa to 2bb260b Compare June 4, 2020 05:22
radtriste
radtriste reviewed Jun 4, 2020
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
hack/go-lint.sh
@@ -1,4 +1,4 @@
#!/bin/env bash
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was change some time ago to #!/bin/env bash
@ricardozanini can you recall why ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ubuntu local clients: https://unix.stackexchange.com/questions/206350/what-is-the-difference-if-i-start-bash-with-bin-bash-or-usr-bin-env-bash/206366

There's no difference to me (between env and bash, despite the security risk pointed in the discussion likned above). The change was from #!/bin/sh to #!/bin/env bash.

[KOGITO-2351] - Integrate golint with PR checks on kogito-cloud-opera…
b084fb1 
…tor repository

See: https://issues.redhat.com/browse/KOGITO-2351

Signed-off-by: Tarun Khandelwal <tarkhand@redhat.com>
ricardozanini
ricardozanini approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @Kaitou786 :)

@spolti spolti merged commit 716940d into apache:master Jun 4, 2020
@radtriste
Copy link
Contributor

@ricardozanini @Kaitou786 Is there any plan to integrate that golangci-lint check into the hack/go-lint.sh ?
because make test is passing on our machines but then CircleCi may fail ...

@radtriste
Copy link
Contributor

https://kie.zulipchat.com/#narrow/stream/232676-kogito/topic/Operator.20and.20golint/near/200070543

@ricardozanini
Copy link
Member

@ricardozanini @Kaitou786 Is there any plan to integrate that golangci-lint check into the hack/go-lint.sh ?
because make test is passing on our machines but then CircleCi may fail ...

Yes :)

@ricardozanini ricardozanini added this to the v0.11.0 milestone Jun 8, 2020
@ricardozanini ricardozanini added ready 🚀 PR is ready to be merged and removed needs review 🔍 Pull Request that needs reviewers labels Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

@spolti spolti spolti approved these changes

@sutaakar sutaakar sutaakar approved these changes

@radtriste radtriste radtriste approved these changes

Assignees
No one assigned
Labels
ready 🚀 PR is ready to be merged
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Kaitou786 @radtriste @ricardozanini @spolti @sutaakar