This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
[KOGITO-2451] Migrate nightly pipelines to RHBA #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radtriste
changed the title
radtriste
force-pushed
the
pipelines-rhba
branch
3 times, most recently
from
bb501b3
to
a8f4729
Compare
radtriste
force-pushed
the
pipelines-rhba
branch
3 times, most recently
from
36af599
to
b836a00
Compare
7 tasks
radtriste
force-pushed
the
pipelines-rhba
branch
from
b836a00
to
97434f3
Compare
Kaitou786
reviewed
Jun 19, 2020
Kaitou786
reviewed
Jun 19, 2020
radtriste
requested review from
Kaitou786
and removed request for
ricardozanini and
spolti
radtriste
changed the title
radtriste
force-pushed
the
pipelines-rhba
branch
3 times, most recently
from
f10b070
to
6dc3c86
Compare
radtriste
force-pushed
the
pipelines-rhba
branch
3 times, most recently
from
a86d759
to
7c910ee
Compare
radtriste
commented
Jun 19, 2020
| @@ -80,7 +81,7 @@ if [[ -z ${CI} ]]; then | |||
| ./hack/go-test.sh | |||
| BUILD_PARAMS="" | |||
| if [[ ! -z ${BUILDER} ]]; then BUILD_PARAMS="${BUILD_PARAMS} --image-builder ${BUILDER}"; fi | |||
| operator-sdk build ${REGISTRY}/${IMAGE}:${TAG} ${BUILD_PARAMS} | |||
| operator-sdk build ${REGISTRY}/${IMAGE}:${TAG} ${BUILD_PARAMS} --go-build-args -o=${BINARY_OUTPUT} | |||
There was a problem hiding this comment.
this will force the output name to kogito-cloud-operator because default, operator-sdk is taking the folder name for the binary and it may not run in a kogito-cloud-operator named folder
radtriste
force-pushed
the
pipelines-rhba
branch
2 times, most recently
from
89371ce
to
bd1c209
Compare
radtriste
commented
Jul 1, 2020
spolti
approved these changes
Jul 1, 2020
radtriste
force-pushed
the
pipelines-rhba
branch
3 times, most recently
from
7b4ec39
to
8943aac
Compare
|
I changed a bit the pipeline to handle correctly the parameters. I find this way much more readable and prone to easier modification.
|
Merged
7 tasks
sutaakar
approved these changes
Jul 2, 2020
spolti
approved these changes
Jul 2, 2020
Kaitou786
approved these changes
Jul 3, 2020
radtriste
force-pushed
the
pipelines-rhba
branch
2 times, most recently
from
1d6dc4c
to
4e9cab0
Compare
sutaakar
reviewed
Jul 3, 2020
|
@radtriste One more thing, can you add also |
|
Is this PR ready to merge? |
|
@sutaakar are you ok with the latest changes ? |
|
yes, looks good |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/KOGITO-2435
and added skip tests parameter
Many thanks for submiting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
[KOGITO-XYZ] Subject